SeattleTestbed / repy_v2

Seattle Testbed's Repy ("Restricted Python") sandbox, version 2
MIT License
12 stars 50 forks source link

[New comer] ntp_time is broken #36

Closed choksi81 closed 10 years ago

choksi81 commented 10 years ago

The translation of ntp_time from repy v1 to repy v2 for the repy v2 node manager branch has a few issues. First, localip is used instead of ip on line 82. Secondly, it should raise an error on failure instead of returning False. Finally, the last two lines, which register the time method, should not be indented.

Additionally, sendmessage should take take an IP for it's first argument rather than a url, but looking at the repy v1 version of ntp_time I'm confused as to why it doesn't have the same problem (assuming that version actually works).