search

SeattleTestbed / repy_v2

Seattle Testbed's Repy ("Restricted Python") sandbox, version 2
MIT License
12 stars 48 forks source link

uniqueid is not unique #56

Open choksi81 opened 10 years ago

choksi81 commented 10 years ago

The root cause of many of the Affix problems is that unique IDs are not unique. This is because if it is imported twice, the numbers will repeat.

This has huge implications not only for uniqueid but other code like random that assumes there is only one copy of the code.

We will commit a temporary work around, but the root cause needs to be fixed and tested.

choksi81 commented 10 years ago

Author: justinc Workaround in r7067. Beware of systems that have low fidelity clocks (Windows?).

choksi81 commented 10 years ago

Author: leonwlaw I believe we can remove the workaround in r7067. I have also added a unit test to verify that unique IDs are returned when uniqueid is imported twice.

https://seattle.poly.edu/attachment/ticket/1319/uniqueid_rollback.patch

Please review and commit.

choksi81 commented 10 years ago

Attachments: https://github.com/SeattleTestbed/attic/blob/master/TICKET_ATTACHMENTS/uniqueid_rollback.patch