SeattleTestbed / seash

Interactive vessel management tool
MIT License
0 stars 10 forks source link

Fixes #99. Removes ancient readline and custom tab completion code in favor of native + std rlcompleter. #100

Closed awwad closed 8 years ago

awwad commented 8 years ago

Please see comments in Issue #99.

Synopsis:

This change removes all that and instead just uses whatever native readline is available on *nix or OS X, and imports rlcompleter to handle tab completion. Yay for less code!

awwad commented 8 years ago

All tests that should pass pass locally (3 failures: ut_seash_getrelease.py, ut_seash_getrelease_insecure.py, ut_seash_moduleconflicterror.py - just as with vanilla). I no longer get the blank false failures on my OS X laptop.

If PR #98 were merged, the tests via AppVeyor and Travis would occur and show up here.

awwad commented 8 years ago

This change also breaks tab completion of local files / folders, which I hadn't previously understood. /:

> loadkeys ~/<TAB>

should provide completion but does not there. Will have to try fixing the code to work with it and issue another PR. (Confusion stemmed from fact that filename tab completion is only available following a command, not on bare line - e.g. > sea<TAB> doesn't display seash.py.)