search

SeattleTestbed / seash

Interactive vessel management tool
MIT License
0 stars 10 forks source link

Remove obsolete files / tests from V2 branch... #65

Open choksi81 opened 10 years ago

choksi81 commented 10 years ago

There are a lot of obsolete files in the V2 branch. They should be removed.

I'll put a list of files here which I think should go....

choksi81 commented 10 years ago

See also seattlelib_v2's issue #133 and repy_v2's issue #67

choksi81 commented 10 years ago

My list of things to kill: shims/ nodemanager/tests/nmtest portability/tests/rhtest*

repy/tests/* ???Use RepyV1 versions ported to utf instead??? (restrictions.default must be moved to testsV2 dir)

repy/testsV2/z_testgetruntime* ???Use ported versions or port???

softwareupdater/test/quickstart.py

seattlelib/Multiplexer.repy seattlelib/natlayer_rpc.repy

seattlelib/test/*

My list of things to move to other projects: affix/*

apps/seobinggo/*

checkapi/*

repy/repyV1/* ???This should be ???

consider moving apps/blockstore ?

seattlegeni/*

Consider moving seattlelib/librepy* and seattlelib/testlibrepy/* to another project.

Other files: resource/Bandwidth isn't really working. We should think about whether or not to include it here. It seems odd to have it in here.

The file: nodemanager/timeout_xmlrpclib.py seems only to be used by openDHT and related integration tests. It looks like opendhtadvertise was moved in r2202, but this file was not. They should be linked / placed together.

Does it make sense to move repy/winAPItests/testWinAPIMutex.py to be with the tests for runonce? If not, is this valid? If it's valid port it.

repy/persist.py should probably be in nodemanager/ instead.

idhelper.py should use uniqueid.repy. (This isn't trivial because of the threadname code, but it should be easy to do.)

softwareupdater/writemetainfo.py and softwareupdater/generatekeys.py should probably be in dist... (Maybe the softwareupdater.py doesn't deserve its own dir?)

seattlelib/fastnmclient.repy ???? USES natlayer_rpc. Is it obsolete? Does it need a port? ???

I would like to remove repyhelper, but these changes are fairly extensive. This warrants a separate ticket. portability/repyhelper.py ?????NEEDS ANOTHER TICKET????? Files I am not sure about: nodemanager/tests/helper_uploadstartprintlog.repy nodemanager/tests/injectconfig.py nodemanager/tests/testnmthreadingerror.py softwareupdater/test/* I'll do seattlelib in another comment

choksi81 commented 10 years ago

All of these are in repyV2/seattlelib/ advertise_test_routine.repy should be moved elsewhere. It is really a repyV2 test script for the advertise service.

advertiseserver_v2.repy isn't a library. It should be moved elsewhere.

As far as I can tell, argparse is not used and is of dubious value. Only the repyV1 "service" keydaemon seems to use it and this is unused / obsolete. Perhaps remove it?

convert_print_to_log.sh is so-so. Keep? Remove?

domainnameinfo.repy likely should be rolled into geoip_client.repy

I think that getvesselresources.repy is obsolete since we have the getresources API call.

Hmm. Librepy is a quandry. It's used by our benchmark scripts and some tests (mostly testlibrepy/). That's it. I feel it really could be improved and made more useful. I'm not sure whether or not it should be included.

nat* is obsolete and should be removed.

One could argue doradvertise and opendhtadvertise could be obsoleted...

I think regsiterhttpcallback is obsolete / broken. It seems to be missing files it tries to include, etc. It has tests, but isn't httpserver serving the same role?

repypp.py is obsolete!

repyunit.repy is obsolete.

Why is restrictions.advertiseserver in this dir?!?

rhizoma.mix is obsolete / was never built.

secureadvertise_server.repy should be moved and secureclient.repy should be with it, I would think.

servicelookup seems very odd / specific. Why have it be a standard lib?

* Related note, nodemanager/servicelookup.py should be refactored *

strace.py seems more like a tool. Maybe include. (Definitely rename...)

The test/ directory has tests that need to be ported over.

tests/test* can be deleted (as far as I can tell).

tests/httpretrieve_test/ seems fine, but why place in a subdir?

tests/sockettimeout_tests/ and tests/testxmlrpc_client/ need to be ported over.

choksi81 commented 10 years ago

I think we should decide not to import things (or at least remove them from the fork) after we import into github. No need to delete them right now..