search

SeattleTestbed / seattlelib_v2

RepyV2 libraries to use with SeattleTestbed
MIT License
1 stars 20 forks source link

Source port detection should use getresources() #126

Open choksi81 opened 10 years ago

choksi81 commented 10 years ago

The RepyV2 network functions make specifying a source port (and IP address) mandatory. A couple of recent fixes (r6955, r6969) introduced logic to parts of SeattleLib that would search for a source port in the usual vessel port range, 63100-63200. I did not foresee in these patches that we might be using non-standard ports. (The unit tests are one such place where we do that; different clearinghouses might also do their own thing.)

Instead of hardcoding the port range to be searched, we should rather use RepyV2's getresources() call to get the list of ports that are actually available per the restrictions file.

choksi81 commented 10 years ago

Author: albert r7149 updates r6969/r7148 for TCP in sockettimeout.repy.

choksi81 commented 10 years ago

Author: albert Replying to albert:

r7149 updates r6969/r7148 for TCP in sockettimeout.repy. Sorry, mixed up release numbers. r7149 updates '''r6955'''/ r7148 for TCP in sockettimeout.repy.

choksi81 commented 10 years ago

Author: albert Fixed for UDP in r7151. Feel free to review.