search

SeattleTestbed / seattlelib_v2

RepyV2 libraries to use with SeattleTestbed
MIT License
1 stars 20 forks source link

Refactor library function names? #176

Open aaaaalbert opened 9 years ago

aaaaalbert commented 9 years ago

In RepyV1, module "imports" were actually inlined using the Repy preprocessor repypp. Module functions were always prefixed with the module name, e.g. advertise_lookup, so that no inadvertent aliasing / name collisions occur. In RepyV2, dylink lets us import modules much like Python's import modulename (see also #137), so we don't need the un-aliasing anymore.

I suggest we refactor the function names across modules to drop the module-name prefix. What do others think?

JustinCappos commented 9 years ago

Yes, this seems like a good idea to me.

Another option is to also alias the names when dylink does the import...

On Thu, Aug 20, 2015 at 12:08 PM, aaaaalbert notifications@github.com wrote:

In RepyV1, module "imports" were actually inlined using the Repy preprocessor repypp. Module functions were always prefixed with the module name, e.g. advertise_lookup, so that no inadvertent aliasing / name collisions occur. In RepyV2, dylink lets us import modules much like Python's import modulename (see also #137 https://github.com/SeattleTestbed/seattlelib_v2/issues/137), so we don't need the un-aliasing anymore.

I suggest we refactor the function names across modules to drop the module-name prefix. What do others think?

— Reply to this email directly or view it on GitHub https://github.com/SeattleTestbed/seattlelib_v2/issues/176.