search

SeattleTestbed / softwareupdater

Software updater daemon
MIT License
1 stars 6 forks source link

software updater test broken: nodemanager restart fails due to hardcoded length in test script #15

Closed choksi81 closed 10 years ago

choksi81 commented 10 years ago

The change of length of the version string in r2414 broke part of the software updater tests (but not the software updater itself). The tests are relying on the version string being an expected length.

The file softwareupdater/test/test_updater.py needs to be changed to allow nmmain.py to have a version string of any length.

Current test output below.

~/workspace/seattle-trunk/tests/updater1$ python test_updater_local.py 
Writing initial metainfo...                                                         
Copying files to /tmp/tmplveiq3/noup folder...                                      
Copying files to wronghash directory                                                
Changing nmmain...                                                                  
Writing updated nmmain.py metainfo...                                               
Warning, 'nmmain.py' has only a hash or file size change but not both (how odd).    
Copying files to /tmp/tmplveiq3/updatenmmain folder...                              
Copying files to corruptmeta folder...                                              
Writing badly signed metainfo                                                       
Copying files to /tmp/tmplveiq3/badkeysig folder...                                 
Changing softwareupdater                                                            
Writing updated softwareupdater.py metainfo                                         
Warning, 'softwareupdater.py' has only a hash or file size change but not both (how odd).
Copying files to /tmp/tmplveiq3/updater folder...                                        
Changing nmmain...                                                                       
Writing metainfo with new valid key                                                      
Warning, 'nmmain.py' has only a hash or file size change but not both (how odd).         
Copying files to /tmp/tmplveiq3/updater_new folder...                                    
Copying back files from noup folder...                                                   
Generating key...                                                                        
Writing config file...                                                                   
Writing vessel dictionary...                                                             
listening for connection on:  128.208.4.16                                               
/tmp/tmplveiq3/noup/                                                                     
Test type: -x URL: http://128.208.4.16:12345/    [ PASS ]                                

listening for connection on:  128.208.4.16
/tmp/tmplveiq3/wronghash/                 
Test type: -e URL: http://128.208.4.16:12345/    [ PASS ]

listening for connection on:  128.208.4.16
/tmp/tmplveiq3/badkeysig/                 
Test type: -x URL: http://128.208.4.16:12345/    [ PASS ]

listening for connection on:  128.208.4.16
/tmp/tmplveiq3/corruptmeta/               
Test type: -e URL: http://128.208.4.16:12345/    [ PASS ]

listening for connection on:  128.208.4.16
/tmp/tmplveiq3/updatenmmain/              
Test type: -u URL: http://128.208.4.16:12345/    [ PASS ]

listening for connection on:  128.208.4.16
/tmp/tmplveiq3/updater/                   
Test type: -u URL: http://128.208.4.16:12345/    [ PASS ]

listening for connection on:  128.208.4.16
/tmp/tmplveiq3/updater_new/               
Test type: -u URL: http://128.208.4.16:12345/    [ PASS ]

listening for connection on:  128.208.4.16
Initial ps out:                           
justin   30292 29994  0 11:07 pts/3    00:00:00 python softwareupdater.py

  File "nmmain.py", line 117
    version = "0.2a"ng"     
                     ^      
SyntaxError: invalid syntax 
Old softwareupdater returned correctly
After ps out:                         
justin   30584     1 44 11:08 pts/3    00:00:01 python softwareupdater.py 0.4863502199

softwareupdater restart success!
listening for connection on:  128.208.4.16
Waiting 2 minutes for the second update to happen
  File "nmmain.py", line 117                     
    version = "0.5a"ng"                          
                     ^                           
SyntaxError: invalid syntax                      
Second update a success!
choksi81 commented 10 years ago

Author: jsamuel Fixed in r2470.