The software updater tests that use a remote location appear to be broken. I think this is just a case of bad or possibly non-deterministic tests rather than the software updater being broken, as I manually tested the software updater quite a bit yesterday.
I'm not considering this a dup of #532 because it is more than just cleanup, they don't actually seem to work. More specifically, some of the individual tests in the beginning pass, but failure seems to happen when trying to restart the software updater.
Here's my output following the instructions at UpdaterUnitTests (I'm not sure I'd consider these unit tests):
/tmp/remotetestfiles/mytestdir$ python test_runupdate.py http://seattle.cs.washington.edu/jsamuel/updatertests/9/
Test type: -x URL: http://seattle.cs.washington.edu/jsamuel/updatertests/9/noup/ [ PASS ]
Test type: -e URL: http://seattle.cs.washington.edu/jsamuel/updatertests/9/wronghash/ [ PASS ]
Test type: -x URL: http://seattle.cs.washington.edu/jsamuel/updatertests/9/badkeysig/ [ PASS ]
Test type: -e URL: http://seattle.cs.washington.edu/jsamuel/updatertests/9/corruptmeta/ [ PASS ]
Test type: -u URL: http://seattle.cs.washington.edu/jsamuel/updatertests/9/updatenmmain/ [ PASS ]
Test type: -u URL: http://seattle.cs.washington.edu/jsamuel/updatertests/9/updater/ [ PASS ]
Test type: -u URL: http://seattle.cs.washington.edu/jsamuel/updatertests/9/updater_new/ [ PASS ]
Initial ps out:
justin 13687 13481 0 16:39 pts/5 00:00:00 python softwareupdater.py
Return code is: None
Wrong return code! None
Second update failed to happen within 2 minutes
The software updater tests that use a remote location appear to be broken. I think this is just a case of bad or possibly non-deterministic tests rather than the software updater being broken, as I manually tested the software updater quite a bit yesterday.
I'm not considering this a dup of #532 because it is more than just cleanup, they don't actually seem to work. More specifically, some of the individual tests in the beginning pass, but failure seems to happen when trying to restart the software updater.
Here's my output following the instructions at UpdaterUnitTests (I'm not sure I'd consider these unit tests):