search

SeattleTestbed / softwareupdater

Software updater daemon
MIT License
1 stars 6 forks source link

Software updater has failures when logging information #18

Closed choksi81 closed 10 years ago

choksi81 commented 10 years ago

For some reason the software updater writes information to stderr. This causes problems because we close the stream.

testbed-mac:v2 gribble$ cat softwareupdater.old 1247510403.0:PID-36232:Traceback (most recent call last): File "softwareupdater.py", line 687, in <module> File "softwareupdater.py", line 388, in init File "softwareupdater.py", line 492, in fresh_software_updater ValueError: I/O operation on closed file

choksi81 commented 10 years ago

Author: justinc Fixed in r2477.

choksi81 commented 10 years ago

Author: jsamuel Related to this, in r2487 I added back writing to stdout if the servicelogger fails and so also removed the closing of stdout/stderr. Note that maybe r2487 should have written to stderr rather than stdout, but the high order bit there was that something can come out if the servicelogger isn't working for some reason (#527).