search

SeattleTestbed / softwareupdater

Software updater daemon
MIT License
1 stars 6 forks source link

software updater code's dry run on startup is useless as currently implemented #21

Closed choksi81 closed 10 years ago

choksi81 commented 10 years ago

The software updater has an init() method that, among other things, claims to be for the purpose of making sure everything works fine before it indicates to a previous software updater that started it that the new one is now taking over so the old software updater can exit. However, the part of the code in init() that does the runthrough of an update is wrapped in a try/except that pass's on all exceptions, so this could never cause the newly-started software updater to exit.

I'll probably remove the code related to calling do_rsync() from the init() method rather than change the code to cause the software updater to exit if the rsync fails. There could be an argument for making it exit, but I think if we wanted to do that we'd want to be careful about the types of exceptions that cause it to exit.

choksi81 commented 10 years ago

Author: jsamuel Fixed in r3218.