SeattleTestbed / softwareupdater

Software updater daemon
MIT License
1 stars 6 forks source link

Race to read vesseldict... #22

Closed choksi81 closed 10 years ago

choksi81 commented 10 years ago

I don't think the persist module is safe for multiple processes to use concurrently. When doing start_seattle.sh I sometimes see:

Traceback (most recent call last):
  File "softwareupdater.py", line 69, in safe_servicelogger_init
  File "/Users/justincappos/Desktop/seattle_repy/servicelogger.py", line 2574, in init
  File "/Users/justincappos/Desktop/seattle_repy/servicelogger.py", line 2527, in get_servicevessel
  File "/Users/justincappos/Desktop/seattle_repy/persist.py", line 187, in restore_object
OSError: [2](Errno) No such file or directory: './vesseldict.tmp'

Perhaps the solution is to copy the file before restoring? The software updater will only need to read the file.

choksi81 commented 10 years ago

Author: cemeyer Fixed in r2597.