SeattleTestbed / softwareupdater

Software updater daemon
MIT License
1 stars 6 forks source link

Added copying of nodemanager files into target #48

Closed choksi81 closed 9 years ago

choksi81 commented 9 years ago

softwareupdater.py imports daemon module. And this requires the files of nodemanager to be copied over to the TARGET dir. Otherwise it throws import error!

aaaaalbert commented 9 years ago

Why is this necessary?

choksi81 commented 9 years ago

It was not able to import daemon module and daemon.py resides in nodemanager.

aaaaalbert commented 9 years ago

When did that happen?

vladimir-v-diaz commented 9 years ago

We encountered this missing dependency issue while trying to update and test softwareupdater.py. It appears that DEPENDENCIES/nodemanager/* must be added to config_build.txt to resolve this issue. You may reproduce this issue as follows:

$ python initialize.py 
Checking out repo from https://github.com/SeattleTestbed/seattlelib_v2 ...
Done!
Checking out repo from https://github.com/SeattleTestbed/portability ...
Done!
Checking out repo from https://github.com/SeattleTestbed/repy_v2 ...
Done!
Checking out repo from https://github.com/SeattleTestbed/common ...
Done!
Checking out repo from https://github.com/SeattleTestbed/nodemanager ...
Done!
$ python build.py
Building into /home/vlad/projects/seattletestbed/temp/softwareupdater/RUNNABLE
Done building!
$ python build.py -t
Building into /home/vlad/projects/seattletestbed/temp/softwareupdater/RUNNABLE
Done building!
$ cd ../RUNNABLE/
$ python utf.py -a
Testing module: softwareupdaters
    Running: ut_softwareupdaters_testupdaterlocal.py            [ FAIL ]
--------------------------------------------------------------------------------
Standard error :
..............................Produced..............................
Traceback (most recent call last):
  File "ut_softwareupdaters_testupdaterlocal.py", line 253, in main
  File "/home/vlad/projects/seattletestbed/temp/softwareupdater/RUNNABLE/test_updater.py", line 187, in create_folders
  File "/home/vlad/projects/seattletestbed/temp/softwareupdater/RUNNABLE/test_updater.py", line 72, in change_nmmain_version
IOError: [Errno 2] No such file or directory: 'nmmain.py'

..............................Expected..............................
None
--------------------------------------------------------------------------------
$ ls
choksi81 commented 9 years ago

I think this pull request ( https://github.com/SeattleTestbed/softwareupdater/pull/48) takes care of it. You can review it and merge it if no problem arises.

On 19 November 2014 13:17, Vladimir Diaz notifications@github.com wrote:

We encountered this missing dependency issue while trying to update and test softwareupdater.py. It appears that DEPENDENCIES/nodemanager/* must be added to config_build.txt to resolve this issue. You may reproduce this issue as follows:

$ python initialize.py Checking out repo from https://github.com/SeattleTestbed/seattlelib_v2 ... Done! Checking out repo from https://github.com/SeattleTestbed/portability ... Done! Checking out repo from https://github.com/SeattleTestbed/repy_v2 ... Done! Checking out repo from https://github.com/SeattleTestbed/common ... Done! Checking out repo from https://github.com/SeattleTestbed/nodemanager ... Done! $ python build.py Building into /home/vlad/projects/seattletestbed/temp/softwareupdater/RUNNABLE Done building! $ python build.py -t Building into /home/vlad/projects/seattletestbed/temp/softwareupdater/RUNNABLE Done building! $ cd ../RUNNABLE/ $ python utf.py -a Testing module: softwareupdaters

Running: ut_softwareupdaters_testupdaterlocal.py [ FAIL ]

Standard error : ..............................Produced.............................. Traceback (most recent call last): File "ut_softwareupdaters_testupdaterlocal.py", line 253, in main File "/home/vlad/projects/seattletestbed/temp/softwareupdater/RUNNABLE/test_updater.py", line 187, in create_folders File "/home/vlad/projects/seattletestbed/temp/softwareupdater/RUNNABLE/test_updater.py", line 72, in change_nmmain_version IOError: [Errno 2] No such file or directory: 'nmmain.py'

..............................Expected..............................

None

$ ls

— Reply to this email directly or view it on GitHub https://github.com/SeattleTestbed/softwareupdater/pull/48#issuecomment-63686691 .

choksi81 commented 9 years ago

Oh, you were replying to Albert's question. I thought you are reporting this issue. I had continued that discussion with Albert on Skype afterwards.

On 19 November 2014 13:50, Chintan Choksi cc4256@nyu.edu wrote:

I think this pull request ( https://github.com/SeattleTestbed/softwareupdater/pull/48) takes care of it. You can review it and merge it if no problem arises.

On 19 November 2014 13:17, Vladimir Diaz notifications@github.com wrote:

We encountered this missing dependency issue while trying to update and test softwareupdater.py. It appears that DEPENDENCIES/nodemanager/* must be added to config_build.txt to resolve this issue. You may reproduce this issue as follows:

$ python initialize.py Checking out repo from https://github.com/SeattleTestbed/seattlelib_v2 ... Done! Checking out repo from https://github.com/SeattleTestbed/portability ... Done! Checking out repo from https://github.com/SeattleTestbed/repy_v2 ... Done! Checking out repo from https://github.com/SeattleTestbed/common ... Done! Checking out repo from https://github.com/SeattleTestbed/nodemanager ... Done! $ python build.py Building into /home/vlad/projects/seattletestbed/temp/softwareupdater/RUNNABLE Done building! $ python build.py -t Building into /home/vlad/projects/seattletestbed/temp/softwareupdater/RUNNABLE Done building! $ cd ../RUNNABLE/ $ python utf.py -a Testing module: softwareupdaters

Running: ut_softwareupdaters_testupdaterlocal.py [ FAIL ]

Standard error : ..............................Produced.............................. Traceback (most recent call last): File "ut_softwareupdaters_testupdaterlocal.py", line 253, in main File "/home/vlad/projects/seattletestbed/temp/softwareupdater/RUNNABLE/test_updater.py", line 187, in create_folders File "/home/vlad/projects/seattletestbed/temp/softwareupdater/RUNNABLE/test_updater.py", line 72, in change_nmmain_version IOError: [Errno 2] No such file or directory: 'nmmain.py'

..............................Expected..............................

None

$ ls

— Reply to this email directly or view it on GitHub https://github.com/SeattleTestbed/softwareupdater/pull/48#issuecomment-63686691 .

vladimir-v-diaz commented 9 years ago

Thank you. I tested this pull request and softwareupdater.py does indeed find nmmain.py after the nodemanager dependency is added to config_build.txt I will run the unit tests for the other repositories to verify that the build scripts are generating all the required dependencies.