Updating the Dockerfile for Python3

[laconc]

Also updating the instructions to build a docker image locally, versus downloading it from DockerHub. With this, it will install the most recent version from master and not a potentially outdated one that is currently manually managed. Alternatively, DockerHub can be set to auto-build an image when master is updated, or for new releases. Someone with write access to the repo can set that up; the work here is a fine way to go, though.

[ebo]

Also, isn't it now Python3 only, not 2?

On Dec 29 2017 7:09 AM, sumpfralle wrote:

sumpfralle commented on this pull request.

it is great, that you took the time to update this recipe!

I added some comments below.

sudo docker run -it \ -v ~/Documents:/root/Documents \ -v ~/.Xauthority:/root/.Xauthority \ -e DISPLAY \ --net=host \

• pycam/run_gui.py
• pycam/pycam

Shouldn't this be pycam/run_gui.py?

@@ -46,7 +50,7 @@ sudo docker run -it \ ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)"

-2. Install the dependencies (currently only for Python2): +2. Install the dependencies (currently only for Python2):

Did you add whitespace on purpose?

@@ -81,13 +85,13 @@ The docker run command will mount your personal Documents folder to `/root/Doc can access your files.

-docker pull pycam/pycam  # downloads the latest image
-IP='<your local ip address>'
+docker build -t pycam/pycam .
+export IP='<your local ip address>'

btw: do you require manual changes here?
Isn't "localhost" sufficient?

>  docker run -it \
     -v ~/Documents:/root/Documents \
     -v /tmp/.X11-unix:/tmp/.X11-unix \
     -e DISPLAY=$IP:0 \
-    pycam/run_gui.py
+    pycam/pycam

As above: `run_gui.py` is correct, or?

[laconc]

@ebo Since only Python3 is supported now, the instructions for running it locally on macOS will fail and will need to be updated. I'm merely doing docker work in this PR, though.

I did take a look at updating the instructions for Mac but ran into a ton of dependency issues.

[ebo]

Fair enough. Just spotted something that I thought I would point out.
Understand grouping changes to tasks...

On Dec 29 2017 8:47 AM, Dashiel Lopez Mendez wrote:

@ebo Since only Python3 is supported now, the instructions for running it locally on macOS will fail and will need to be updated. I'm merely doing docker work in this PR, though.

I did take a look at updating the instructions for Mac but ran into a ton of dependency issues.

[sumpfralle]

Thank you!