search

SebKuzminsky / pycam

Other
341 stars 99 forks source link

Fixed scaling to work with 2d (dxf/svg) models. #166

Closed NikSays closed 4 years ago

NikSays commented 4 years ago

I had a problem, that I couldn't scale 2d files to a certain size due to "Model transformation 'scale' does not accept zero as a target size" Fixed it by not resizing an axis at all if axis' size is 0.

This shouldn't introduce any bugs with 3d models, as it's impossible to fully flatten a 3d model in PyCAM, but any 2d path can be scaled to any size

sumpfralle commented 4 years ago

@NikSays: I am a bit confused, as you just closed the PR? :)

Maybe you misunderstood my comment:

I would be happy to merge such changes!

This means, I would be glad to merge such a contribution from you. Thus feel free to update your commit in the way we discussed. This would be the approach that would make sure, that your contribution is properly attributed to you as the author.

But if you do not feel like putting more time into this issue, then I would create a commit myself (including a grateful Thanks, NikSays!).

Since I value proper crediting (for others), I would prefer the first option. But you may pick, what you like ...

NikSays commented 4 years ago

I'm sorry for confusion. I don't know everything about pull requests, and didn't know how to undo commits in this one, so I opened #167 (I really should have wrote this before closing)

sumpfralle commented 4 years ago

No worries - this is fine. Thank you!