search

SebKuzminsky / pycam

Other
341 stars 99 forks source link

Rrequirements seem to be not complete #191

Open jalovisko opened 3 years ago

jalovisko commented 3 years ago

The requirements in the documentation do not seem to be complete. Ideally, it would be even better to specify versions of the libraries used because there is no guarantee that any future version of a dependency would not break the whole project. I feel like defining these dependencies further with versions in the documentation and in the requirements.txt is better way to go. I have found the set of requiremnts that seem to be working well on Linux and I can make a PR with them.

petterreinholdtsen commented 2 years ago

Why do you ask, instead of just creating the PR to let others have a look at your proposal? Locking versions to a specific one will block any security fixes in dependencies to flow automatically into new installations, so there is a downside to fixed versions in requirements too. No idea which feature is most important here, though.