Keybindings customization

fsioni commented 2 years ago

I added the possibility to change the Keybindings in the already existing menu.

It uses the old input system, not the new one with input action.
Everything is working fine : from movement, to camera, etc.
You can change the keybind of all the actions that was set in the previous version of the file Keybindings.cs
Assigning an already used key : change the older to None and assign to the new action
How to make it work ? Add a button with the tag 'Keybind' and the name of the corresponding action (the same name as configured in the script)
Added an 'invert elevation' that just inverts the 'pitch up' and 'pitch down' buttons

https://user-images.githubusercontent.com/82713835/167036496-95ebc4d5-951b-48d3-9909-fb49c6e37152.mov

I modified the 'Controls' tab in the settings. Feel free to make it look better or to add/delete commands

If this PR is accepted, I plan to implement persistence of preferences between sessions and a button to reset to the defaults keybinds

fsioni commented 2 years ago

Works only when the 'Settings Menu' GameObject is active on start : working on correction

fsioni commented 2 years ago

Bug fixed ✅

SebLague commented 2 years ago

Hi, thanks for contributing. This is looking good, however I do not want to revert back to the old input system as the new one seems to have better support for various gamepads (which I have already partially implemented), and is nicer to work with in my opinion. If you're willing to change this to use the new input system + make rebinds persist between sessions then I'd love to merge it. Thanks again for the effort!

fsioni commented 2 years ago

Hi, thanks for contributing. This is looking good, however I do not want to revert back to the old input system as the new one seems to have better support for various gamepads (which I have already partially implemented), and is nicer to work with in my opinion. If you're willing to change this to use the new input system + make rebinds persist between sessions then I'd love to merge it. Thanks again for the effort!

Hi Sebastian ! I understand your willing to keep the new Input System. Actually, I realised that there you started to implement the new one after I finished my PR.

I hope that my next contribution will live up to expectations :)

SebLague / Geographical-Adventures

Keybindings customization #50