Closed fsioni closed 2 years ago
Great work, thank you! There are a few small issues that need to be addressed before I merge this (if you don't want to work on this any further btw, feel free to leave the pr open and I will make the changes myself later when I have time).
Low priority (not necessary for merge)
Great work, thank you! There are a few small issues that need to be addressed before I merge this (if you don't want to work on this any further btw, feel free to leave the pr open and I will make the changes myself later when I have time).
- Font size should match rest of settings menu (30 instead of 36)
- For some reason I am unable to bind the 'E' key to anything.
- For consistency with the rest of the settings menu, rebindings should not be saved if you exit without first pressing 'Apply'.
- If you click to rebind a control, then exit the menu (or change to a different settings tab) without binding a key, you're still able to rebind the control from outside of the menu.
Low priority (not necessary for merge)
- You should not be able to rebind multiple keys at once (clicking on one rebind button while another is active should automatically deactivate the old one).
Thanks 🙂 Glad that it almost suits the project ! I will definitely improve the system with your advice and few other things ! I will work on this 👌
Hello Sebastian !
Fantastic work, thank you!
Hello again :) I opened this new PR because I didn't manage to discard the old and obsolete commit.
By selecting the right Input Action, you drag the 'selected binding' to select the right input (keyboard, gamepad...)
https://user-images.githubusercontent.com/82713835/167273547-5f2b3543-67bc-4230-8e71-c988ec4f1f7e.mov
Hope this PR is now OK :)