search

SebLague / Portals

Portals in Unity
https://www.youtube.com/watch?v=cWpFZbjtSQg
MIT License
773 stars 167 forks source link

GLSL Compilation failed #1

Closed rendoir closed 4 years ago

rendoir commented 4 years ago

Error description: When importing the project, Unity throws an error regarding a failure in compiling the Portal shader.

Shader compilation error

Source of the problem: This is happening because there is a variable called active in the Portal.shader while the GLSL Specification for OpenGL 4.60 considers the keyword active to be "reserved for future use" and warns that "using them will result in a compile-time error".

Possible solution: The simplest solution is to change the name of the variable active to, for example, displayMask.

Software details: I'm using Ubuntu 18.04 with NVIDIA proprietary 435 drivers. I tested in Unity 2019.3.2f1 being run on OpenGL.

SebLague commented 4 years ago

I accepted your pull request, thanks!