search

SebaSOFT / walls-have-ears

A simple-as-possible FoundryVTT module to muffle sounds that are behind a wall for a player.
MIT License
8 stars 5 forks source link

Popping noise when moving token #28

Closed TehSl0th closed 2 years ago

TehSl0th commented 2 years ago

Hello, I have been experimenting with this module for a little while and noticed that whenever a token is moved, a pop noise happens. This happens when one moves their own token and when someone else moves their token. I checked out one of your videos on YouTube if this was a user issue and not a module issue and heard the same popping noises there when you moved the token. Is there a way to get rid of this noise or is it a side effect of updating the lowpass filter on the move? Otherwise, this is a solid sound enhancement.

Link to video: https://youtu.be/pT5mhNLVPlQ

SebaSOFT commented 2 years ago

Popping sound is an issue if the driver not detecting the removal of the filter node from the node chain. I went to some extent to detect this, but I think I could cache the muffling level and not do anything if is the same, but will further test to see that this is still happening. The video you are referring is from an old version of the mod which should work lots better now. Thanks for the report! I will take it into consideration!

SebaSOFT commented 2 years ago

Try this again and open a new ticket if your are experiencing the same effect. Now the plugin uses a level cache to avoid changing the filter if its not needed. Filters are still being changed and that perhaps is the popping sound, but it should be greatly rectified.