SebaUbuntu / android_packages_apps_Aperture

CameraX based camera app for LineageOS - releases here https://sebaubuntu.dev/lineageapps.html
85 stars 23 forks source link

Selfie: Fix top bar in video mode #36

Closed Dhina17 closed 2 years ago

SebaUbuntu commented 2 years ago

Screenshot_20220810-200944_Camera Looks fine?

luk1337 commented 2 years ago

Not sure what this is about, but I just reformatted your commit msg.

SebaUbuntu commented 2 years ago

Screenshot_20220810-200944_Camera Looks fine?

(this is w/o this commit btw) Are you testing on a 16:9 device?

Dhina17 commented 2 years ago

Not sure what this is about, but I just reformatted your commit msg.

For me, in the video mode, top bar is hidden under the PreviewView.

SebaUbuntu commented 2 years ago

Not sure what this is about, but I just reformatted your commit msg.

For me, in the video mode, top bar is hidden under the PreviewView.

Mind sending a screenshot? Unless you're testing with my aspect ratio commits we're using a ConstraintLayout so it shouldn't happen at all

Dhina17 commented 2 years ago

Screenshot_20220810-200944_Camera Looks fine?

(this is w/o this commit btw) Are you testing on a 16:9 device?

with my Redmi 7. Not sure . let me send a video without this commit

Dhina17 commented 2 years ago

Not sure what this is about, but I just reformatted your commit msg.

For me, in the video mode, top bar is hidden under the PreviewView.

Mind sending a screenshot? Unless you're testing with my aspect ratio commits we're using a ConstraintLayout so it shouldn't happen at all

Check this video. https://imgur.com/a/2XrnquW I haven't tested your aspect ratio commit yet

Dhina17 commented 2 years ago

May be I should move the view as you did in your staging branch instead of adding elevation

SebaUbuntu commented 2 years ago

With aspect ratio commits and 16:9 mode Before: Screenshot_20220810-214533_Camera After: Screenshot_20220810-214346_Camera

It covers a part of the preview view, I don't think that's a good thing

Dhina17 commented 2 years ago

with the new UI, No need for this anymore.