Closed Dhina17 closed 2 years ago
Not sure what this is about, but I just reformatted your commit msg.
Looks fine?
(this is w/o this commit btw) Are you testing on a 16:9 device?
Not sure what this is about, but I just reformatted your commit msg.
For me, in the video mode, top bar is hidden under the PreviewView.
Not sure what this is about, but I just reformatted your commit msg.
For me, in the video mode, top bar is hidden under the PreviewView.
Mind sending a screenshot? Unless you're testing with my aspect ratio commits we're using a ConstraintLayout so it shouldn't happen at all
Looks fine?
(this is w/o this commit btw) Are you testing on a 16:9 device?
with my Redmi 7. Not sure . let me send a video without this commit
Not sure what this is about, but I just reformatted your commit msg.
For me, in the video mode, top bar is hidden under the PreviewView.
Mind sending a screenshot? Unless you're testing with my aspect ratio commits we're using a ConstraintLayout so it shouldn't happen at all
Check this video. https://imgur.com/a/2XrnquW I haven't tested your aspect ratio commit yet
May be I should move the view as you did in your staging branch instead of adding elevation
With aspect ratio commits and 16:9 mode Before: After:
It covers a part of the preview view, I don't think that's a good thing
with the new UI, No need for this anymore.
Looks fine?