search

Sebane1 / RoleplayingVoiceDalamud

Spoken in game voices, enhanced mod management, Twitch integration, and more!
MIT License
24 stars 10 forks source link

Battle Voices Being Played while Crafting #11

Closed TheOddball closed 1 year ago

TheOddball commented 1 year ago

Custom battle voicelines play while crafting, this doesn't seem like intended behavior. I think at minimum a selectable option would be necessary.

Sebane1 commented 1 year ago

This actually poses an interesting problem. I failed to consider that the game might put crafting actions in Battle Chat (I don't craft).

I could probably look at the players current class and blacklist crafting classes from having generic combat sounds, but allow specifically named actions to have sounds if a person wants voice lines on their crafting actions.

TheOddball commented 1 year ago

Yes. Crafters and gatherers output data to Battle Chat. That does seem like the best option for this case :)

TheOddball commented 1 year ago

Fixed by https://github.com/Sebane1/RoleplayingVoiceDalamud/commit/1319c464237cf0f88b58aaa5b7c155f184af46df Thank you!