Sebane1 / RoleplayingVoiceDalamud

Spoken in game voices, enhanced mod management, Twitch integration, and more!
MIT License
23 stars 10 forks source link

Feature request/possible contribution: user preference for which NPC voices to use #22

Closed logarrhythmic closed 3 months ago

logarrhythmic commented 4 months ago

I might try my hand at forking and implementing this myself, since the code looks like this should be very simple to add. Config dropdown -> override for the VoiceLinePriority passed to GetCharacterAudio in AddonTalkHandler.cs. Actually, I think it would be best to make the dropdown have "Always ARK/Prefer ARK/Prefer XIVV/Always XIVV", and still use the current character-specific and combat overrides for the Prefer options.

Sebane1 commented 3 months ago

The current plan will be to hybrid merge the two projects together taking the best elements of both through feedback. This way lines reports and such don't get confused as "Was it for this, or that voice project?" And things are one cohesively curated thing.

There are aspects of ARKs voicing where I think XIVV is objectively better, and vice versa. I'd rather use what sounds best for each particular character. Majority of side NPC's are currently now XIVV, and as we comb through MSQ characters there's been decisions on which voice project had a better fitting voice which has been more nuanced. XIVV got to keep some characters, and Artemis got to keep some characters.

Ultimately one cohesive vision will streamline things a bit more.