search

SebastJava / mint-yz-theme

Mint-Yz: new colors for a new era
GNU General Public License v3.0
53 stars 6 forks source link

$suggested_color on default action button (Save) #34

Closed SebastJava closed 2 years ago

SebastJava commented 2 years ago

_common.scss:

.button {
[...]
  &.default {
    background-color: $suggested_color;
    color: white;
  }
[...]
}
SebastJava commented 2 years ago

I'm not sure this is a good idea. It reminds me of release v2.0.1:

FIXED button focus having same color as selected. Now focused buttons only have their borders being coloured.

SebastJava commented 2 years ago

I've been thinking about this one but think I'd prefer not to go this way. You could easily end up with essentially conflicting things. A logout or shutdown dialog come to mind. The default button could be shutdown but in Cinnamon, for example, this has the destructive class. I think I'd prefer to leave it to applications to decide what style this receives.

Originally posted by @JosephMcc in https://github.com/linuxmint/mint-themes/issues/240#issuecomment-1166606137