search

SebastJava / mint-yz-theme

Mint-Yz: new colors for a new era
GNU General Public License v3.0
52 stars 5 forks source link

Border highlighting of focused windows matching the theme colors. #54

Open the-saddest-clown opened 1 year ago

the-saddest-clown commented 1 year ago

Is your feature request related to a problem? Please describe.
Better visibility of focused windows when using dark themes. See linuxmint/mint-themes/issues/426

Describe the solution you'd like
Border coloring according to the theme color on the focused window.

Screenshots
Capture d’écran_2023-01-25_23-40-51 This is a Xfwm4 window modified with the #E8602E orange from the Mint-Yz-Dark-Orange70s theme.

Additional context
When having lot of windows open while using a dark theme it can sometimes be difficult to quickly differentiate which one have the focus. Adding a color border to the focused window may resolve the issue.

SebastJava commented 1 year ago

Yes. I agree something should be done. Especially on the dark themes. But not forgetting the light (base) themes too. I saw your https://github.com/linuxmint/mint-themes/issues/426 and i saw the other issue you are referring to there.

This thin border works pretty well here, with the sharp contrast between orange and dark gray. But i am not so sure about all the other color combinations. I could try something with a 2 px border, but JosephMcc said somewhere else that he wasn't sure if it could be possible to get a 2px thick border, not just this 1px thickness.

Or it could be something else. Maybe some change on the title bar's background. There should be some more accent on the focused window, somehow, and also, just more contrast between the background and the border, focused or not.

P.S.: I am currently very busy. I hope i will be back working on the GTK themes sometime before April...

the-saddest-clown commented 1 year ago

I haven't tested with all the colors but in general the result is pretty nice. I must admit that I really like the Orange70's with the dark theme. In my opinion 1px is enough to not be distracting, especially when using bright colors on a dark theme but, yes maybe a 2px border would fit better on a light theme. Keep up the good work, I really enjoy your theme. If I were able to tweak the gtk themes I would fork your theme with the border color edition but I'm stuck with gtk editing at this moment. Still trying tho.

SebastJava commented 1 year ago

@the-saddest-clown Sorry for not doing any work on this. Here is why: https://github.com/SebastJava/mint-yz-theme/discussions/57

(In there, you will also find some hints about what is possibly coming up next...)