search

SebastiaanKlippert / go-wkhtmltopdf

Golang commandline wrapper for wkhtmltopdf
MIT License
1.06k stars 146 forks source link

Use of exec.ErrDot requires Go 1.19+ #104

Closed rodaine closed 1 year ago

rodaine commented 1 year ago

Howdy, and thanks for providing this module!

exec.ErrDot was added to Go in version 1.19. Because this module has a dependency on that sentinel error, specifying the minimum Go version in the mod file helps consumers know the minimum supported Go version. (You may have run into this when setting up the matrix tests, where the 1.18 build was failing.)

I recently attempted to install the latest version of go-wkhtmltopdf on a Go 1.18 project and it gave no warning until compile time that it was incompatible. Adding the version here will (theoretically) present an appropriate warning/error that the module is not compatible with an older version of Go.

SebastiaanKlippert commented 1 year ago

Thanks, I forgot to update that.