search

SebastianBoldt / Jelly

🌊 - Jelly is a library for animated, non-interactive & interactive viewcontroller transitions and presentations with the focus on a simple and yet flexible API.
http://www.sebastianboldt.com/
MIT License
2.45k stars 121 forks source link

Assignment Branch Condition too high in JellyPresentationController.align #20

Closed SebastianBoldt closed 5 years ago

SebastianBoldt commented 7 years ago

https://hub.codebeat.co/docs/software-quality-metrics#assignment-branch-condition

SebastianBoldt commented 7 years ago

I am currently not 100% sure what to do. Making evertything public inside the PresentationModels seems to me like a bad code smell and could lead to result in local reasoning problems. I will remove this enhancement from the next release and try to find a better approach of solving this issue in a future version.