search

SebastianBoldt / Jelly

🌊 - Jelly is a library for animated, non-interactive & interactive viewcontroller transitions and presentations with the focus on a simple and yet flexible API.
http://www.sebastianboldt.com/
MIT License
2.45k stars 123 forks source link

Jelly fixes #28

Closed artemnovichkov closed 7 years ago

artemnovichkov commented 7 years ago
SebastianBoldt commented 7 years ago

17 days ago? I am not sure why I missed this PR. I will go through it all at the Weekend. Thanks in advance for contributing to Jelly.

artemnovichkov commented 7 years ago

@SebastianBoldt why you didn't merge my PR?

SebastianBoldt commented 7 years ago

@artemnovichkov I wasn't sure about all the type inference changes. It is said to have a big impact on compile times and I really don't want that my library slows down the compiling process of other developers. But I think that the adaptions you made are okay. So could you please resolve the conflicts? I will merge it then. Best regards.

SebastianBoldt commented 7 years ago

@artemnovichkov Your commit messages are a bit exaggerated. "Update complete transition logic" 😄 .. come on? What you did is that you changed the parameters according to the documentation. It has nothing to do with a complete "Refactoring". Please be a little bit more honest with your next PR.

SebastianBoldt commented 7 years ago

@artemnovichkov resolved it by myself 😄 . Thanks for contributing to Jelly.