search

SebastianBoldt / Jelly

🌊 - Jelly is a library for animated, non-interactive & interactive viewcontroller transitions and presentations with the focus on a simple and yet flexible API.
http://www.sebastianboldt.com/
MIT License
2.45k stars 123 forks source link

Add alpha associated value to BackgroundStyle.dimmed #32

Closed JustinM1 closed 7 years ago

JustinM1 commented 7 years ago

Gives more flexibility when using BackgroundStyle.dimmed, allows touchBackgroundToDismiss with a completely transparent background, provides opportunity to remove .none case in a future release.

SebastianBoldt commented 7 years ago

Looks very good at first sight, but I will take a more detailed look on it on the Weekend. Thanks in advance for contributing to Jelly.

JustinM1 commented 7 years ago

Your very welcome, thanks for the great framework.

SebastianBoldt commented 7 years ago

Could you please create a new PR for the Develop Branch. The Master should only contain the state of the last released version. #gitflow

JustinM1 commented 7 years ago

my apologies, self taught developer who doesn't have much knowledge in the best practices of pull requests/merging into other projects. Will make a new PR