search

SebastianBoldt / Jelly

🌊 - Jelly is a library for animated, non-interactive & interactive viewcontroller transitions and presentations with the focus on a simple and yet flexible API.
http://www.sebastianboldt.com/
MIT License
2.45k stars 121 forks source link

Flashing blur effect when swiping up on top of controller #63

Closed glisom closed 5 years ago

glisom commented 5 years ago

Love the library! Literally makes life so much easier. Currently seeing a flash whenever a user swipes up from the top of the controller inside the animator when using the blur effect. Let me know what info would help, I can attach pics or a video.

SebastianBoldt commented 5 years ago

Hi @glisom , I am totally aware of this issue. It has to do with the animation of the blur view alongside the transitioning coordinator. I will try to inspect this later again. I already implemented a workaround some weeks ago , which animates the alpha of the blur view instead of the blur itself. But this did look weird to me. I will keep you informed about my progress in here. Stay tuned and have a nice day.

glisom commented 5 years ago

@SebastianBoldt awesome, glad to hear. I would like to take a stab at it if that’s cool with you. Do you have a format or anything for PR’s?

SebastianBoldt commented 5 years ago

There is no format or anything. Just change the things how you think it should be done and let’s talk again when the pull request is open 😋. Fyi: I am off for the next 2 days so it maybe takes some time for my next response to arrive.

If you want to dig into the code you can take a look at the PresentationController class, there is a function called animateBlurView which will be called in dismissalTransitionWillBegin and presentationTransitionWillBegin. Setting the blur view to nil will actually animate correctly alongside the transitioning coordinator but there is this tiny glitch you experienced if the user lifts his finger on certain states of transition. Maybe you can find a good solution for this.

See you later 🐊 and have a nice weekend 👋.

SebastianBoldt commented 5 years ago

Hi @glisom. Have you made any progress?

glisom commented 5 years ago

I’ve made some around getting the transition from stopping from flashing but still working on getting it to stop when the transition gets canceled