search

SebastianBoldt / Jelly

🌊 - Jelly is a library for animated, non-interactive & interactive viewcontroller transitions and presentations with the focus on a simple and yet flexible API.
http://www.sebastianboldt.com/
MIT License
2.45k stars 123 forks source link

Request to put back Minimum deployment target to iOS 10 #69

Closed marcmatta closed 5 years ago

marcmatta commented 5 years ago

@SebastianBoldt Thank you for this great library!

Can you please explain for which reasons other than for using the maskedCorners property of the CALayer is the minimum deployment target set to iOS 11?

Although iOS 10 is not recent anymore, users are still using it and if you bring back support you will be covering close to 99% of all users.

All this requires a simple change. One similar provided by this gist

SebastianBoldt commented 5 years ago

Hi @marcmatta, sorry for replying this late. I am currently a little busy and and in addition to that its summertime ;). This weekend the weather should be shitty so i will take a look at this and provide a new release with support for iOS 10.

SebastianBoldt commented 5 years ago

@marcmatta Another reason why i chose iOS11 as a deployment target was the "name" property of the UIGestureRecognizer. I added version guards to the affected code so you will be able to use Jelly in iOS 10.

https://github.com/SebastianBoldt/Jelly/commit/65ed770c81c8e1622e817f26e97e53f9472ffadf

SebastianBoldt commented 5 years ago

https://github.com/SebastianBoldt/Jelly/releases/tag/2.2.1