search

SebastianBoldt / Jelly

🌊 - Jelly is a library for animated, non-interactive & interactive viewcontroller transitions and presentations with the focus on a simple and yet flexible API.
http://www.sebastianboldt.com/
MIT License
2.45k stars 123 forks source link

iOS 13 Support #71

Closed RocZhang9673 closed 5 years ago

RocZhang9673 commented 5 years ago

Hi, I have tried to use Jelly on iOS 13 beta, And I found almost every type of transition doesn't seemed to meet expectations (And I also found an issue here later: https://github.com/SebastianBoldt/Jelly/issues/70).

I think the major reason here is Jelly will create and return a new property animator every time UIViewControllerAnimatedTransitioning's interruptibleAnimator(using transitionContext: UIViewControllerContextTransitioning) method been called. But according to Apple's document (https://developer.apple.com/documentation/uikit/uiviewcontrolleranimatedtransitioning/1829434-interruptibleanimator), We should return the same animator object for the duration of the transition. But I don't know why it still looks well on iOS 12 and earlier versions even if you don't return the same animator in this method.

I have tested my code on both iOS 13 beta 5 simulator and iPhone. Every type of transition in the demo app works well just like them before.

And thank you for bringing such a great transition animation library to us.

Roc

SebastianBoldt commented 5 years ago

Hey @RocZhang9673, i will take deeper look at this soon.