search

SebastianM-C / LaserTypes.jl

A common interface for different laser types
MIT License
4 stars 0 forks source link

Take the real part of the complete field #30

Closed SebastianM-C closed 3 years ago

SebastianM-C commented 3 years ago

I think that the previous implementation was wrong since we have to take the real part of the complete filed, not just a part of if. Multiplying with cos(ωt) is not correct either.

codecov[bot] commented 3 years ago

Codecov Report

Merging #30 (ebe7822) into master (94346f7) will not change coverage. The diff coverage is 85.71%.

:exclamation: Current head ebe7822 differs from pull request most recent head f32fc93. Consider uploading reports for the commit f32fc93 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master      #30   +/-   ##
=======================================
  Coverage   97.22%   97.22%           
=======================================
  Files           8        8           
  Lines         144      144           
=======================================
  Hits          140      140           
  Misses          4        4
Impacted Files Coverage Δ
src/envelopes.jl 82.60% <66.66%> (ø)
src/electricfield.jl 100.00% <100.00%> (ø)
src/magneticfield.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 94346f7...f32fc93. Read the comment docs.