search

SebastianRask / Pocket-Plays-for-Twitch

Open source Twitch client for Android
GNU General Public License v3.0
63 stars 14 forks source link

Build instructions #11

Closed alexzorin closed 5 years ago

alexzorin commented 5 years ago

Hey Sebastian,

This is my daily Twitch driver since a while (and it rocks) but could definitely do with some extra love. There's a few bugs and features that I'd love to write and send PRs for.

Would you be able to provide some help with build instructions and buildability in general?

Some of the first barriers I've run into are:

Probably obvious why they are missing, but it also means building a development version isn't currently possible without some involved ripping out of Google's tendrils from the code.

Any help? Much appreciated!

SebastianRask commented 5 years ago

Hey there,

First of all, thank you for the nice words.

Very weird that SecretKeys.java has been removed. You can use this for development, though you will have to log into a twitch user and Chromecast is not supported:

package com.sebastianrask.bettersubscription.misc;
/**
 * Created by sebastian on 24/07/2017.
    Add Keys
 */
public class SecretKeys {
    public static final String TWITCH_CLIENT_ID = "s9r26uney64y60m9g267600jb6n2lr"; // Development Key
    public static final String CHROME_CAST_APPLICATION_ID = "CC1AD845"; // Dummy key. App host ed by google
    public static final String IN_APP_PURCHASE_BASE64_KEY = ""; 
    public static final String NO_LOG_IN_ACCESS_TOKEN = "";
}

I'll see what i can do about the missing google-services.json file.

alexzorin commented 5 years ago

Appreciate it! That did the trick.

Regarding google-services.json, I used the google-services_old.json file present in the app/ directory and that seems to have gotten me where I needed to go.

novatorem commented 4 years ago

Can I ask what NO_LOG_IN_ACCESS_TOKEN is supposed to hold? Can I replace it with my own account's or did you get a token from twitch for general access?

When I tried logging in from the simulator, I just got a white screen - so I can't access anything in the sim without being to log in and without the no login access token.

SebastianRask commented 4 years ago

Sure you can replace it with an access token from your own account, but that would make no difference if you are already signed in.

Since the Twitch api requires an access token, the value stored in this constant will be used if no user is signed in.

On Fri, Mar 20, 2020, 18:08 Andrew Novac notifications@github.com wrote:

Can I ask what NO_LOG_IN_ACCESS_TOKEN is supposed to hold? Can I replace it with my own account's or did you get a token from twitch for general access?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/SebastianRask/Pocket-Plays-for-Twitch/issues/11#issuecomment-601811836, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5UCJGR4TPPNB535AT4MV3RIOPHFANCNFSM4F3WR65A .

novatorem commented 4 years ago

So when you did it yourself you just made a dummy account and that's the account being used when a user isn't logged in?

SebastianRask commented 4 years ago

Exactly

On Sun, Mar 22, 2020, 03:11 Andrew Novac notifications@github.com wrote:

So when you did it yourself you just made a dummy account and that's the account being used when a user isn't logged in?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/SebastianRask/Pocket-Plays-for-Twitch/issues/11#issuecomment-602136831, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5UCJD7OEG3D7A3WSHNH6DRIVXVVANCNFSM4F3WR65A .