SebastianRask / Pocket-Plays-for-Twitch

Open source Twitch client for Android
GNU General Public License v3.0
62 stars 14 forks source link

Support for subscribe streak icons/additional badges #13

Open Phoenix616 opened 5 years ago

Phoenix616 commented 5 years ago

Currently the chat only displays the standard, new subscriber icon in front of a user's name. It would be nice for it to also support the streak icons (maybe this should wait until cumulative subscriptions are rolled out because they might change the api?)

Edit: Seems like the userstate API includes a badges paramater now that needs to be read for that info: https://dev.twitch.tv/docs/irc/tags#userstate-twitch-tags (and to get all the new badges like bits or twitchcon visitor)

alexzorin commented 5 years ago

I added support for this (global + channel badges, e.g. sub streaks) in my fork - https://github.com/alexzorin/Pocket-Plays-for-Twitch/commit/9b2744e4e0fd78afc1cc6f4efbe5aa7bffaca09c

Unfortunately the commit isn't totally clean (also added TLS enforcement for chat and accidentally committed some cruft in .idea/), but if @SebastianRask is willing to review it, I can send a PR.

SebastianRask commented 5 years ago

@alexzorin I'm more than willing to look at it if you send a PR.