search

SebastianSimon / firefox-omni-tweaks

A script that disables the clickSelectsAll behavior of Firefox, and more.
MIT License
43 stars 8 forks source link

partially broken by firefox-esr 102→115 upgrade #24

Closed mirabilos closed 1 year ago

mirabilos commented 1 year ago

Description

After getting the firefox-esr upgrade shoved onto my system because 102 got EOL’d, fixfx reports an error:

Fixing Firefox…
sed: can't read /tmp/fixfx-browser_omni/modules/UrlbarInput.jsm: No such file or directory
Warning: Pattern 's/(this\._preventClickSelectsAll = )this\.focused;/\1true;/' could not be matched in file 'modules/UrlbarInput.jsm'.

The code seems to have moved:

$ fgrep ._preventClickSelectsAll *
UrlbarInput.sys.mjs:      !this._preventClickSelectsAll &&
UrlbarInput.sys.mjs:        this._preventClickSelectsAll = this.focused;
UrlbarInput.sys.mjs:          this._preventClickSelectsAll = true;

Ideally the code would be compatible with old and new versions of the browser, but I’ve not got the spoons to offer a PR, sorry.

mirabilos commented 1 year ago

oh nevermind, I was on the wrong branch, this seems fixed