SebastianStehle / mjml-net

.NET Fork of MJML library with 10x performance and (almost) all features.
MIT License
144 stars 13 forks source link

MjImage is malformed #160

Closed farhadnowzari closed 1 year ago

farhadnowzari commented 1 year ago

Hi,

thanks for the great library, I was just reading the code and realized you have implemented mjml without nodejs cool ^^;

The issue I experiences which is minor but want to make sure that it won't be problematic was rendering the following sample: https://mjml.io/try-it-live/De-2ZNLsr

The sample above is from mjml and after rendering using mjml-net the image at the top is full width instead if 150px. But if I put it into a <mj-tabl> and use normal <img> then it will work, but wanna make sure that this will be consistent through other mail engines

SebastianStehle commented 1 year ago

Hi,

thanks a lot for the bug report. Unfortunately I cannot reproduce it.

farhadnowzari commented 1 year ago

Hi,

thanks a lot for the bug report. Unfortunately I cannot reproduce it.

Hi, thanks for your reply.

this is the result I get.

image

I tested the generated html in https://app.postdrop.io/

farhadnowzari commented 1 year ago

Hi, thanks a lot for the bug report. Unfortunately I cannot reproduce it.

Hi, thanks for your reply.

this is the result I get.

image

I tested the generated html in https://app.postdrop.io/

well, nevermind I think it is an issue with that test website, because the actual mjml generated html get's malformed

SebastianStehle commented 1 year ago

O added the sample template to our tests and it shows no errors. I also opened the generated file using edge and it looked identical to me.

farhadnowzari commented 1 year ago

O added the sample template to our tests and it shows no errors. I also opened the generated file using edge and it looked identical to me.

I think the issue was with that website. I tested the library last night with our notification service and it worked very fine on different mail engines. I will close this.

SebastianStehle commented 1 year ago

Thanks for the update