search

SebastienWae / app-launcher

Launch application from Emacs
GNU General Public License v3.0
32 stars 13 forks source link

app-launcher-list-apps: Symbol’s value as variable is void: counsel-linux-apps-faulty #6

Open elizagamedev opened 2 years ago

elizagamedev commented 2 years ago

I had some faulty desktop files (i.e. apps with an empty Name field) and this error occurred. This seems to be a leftover from the counsel package.

Vivien-lelouette commented 2 years ago

I have the exact same error. I am not yet an expert on Desktop files debuging. Do you have a way to find out which Desktop file causes the issue ?

I am going to debug this on the Emacs side in the near future, but if there is a more efficient way I'll be happy to know it :)

Note: I do think this should be excluded from the result instead of throwing an error. If I have time in the following weeks (highly unlikely), I might try to fork and code this behaviour.

Vivien-lelouette commented 2 years ago

Turns out you just need to remove the push to that variable. The entry is already skipped, only this push causes the crash.

I made a fork available here: https://github.com/Vivien-lelouette/app-launcher. There is only this line removal in the HEAD. @SebastienWae, should I make a merge request ?