search

Sebobo / Shel.Neos.CommandBar

A commandbar (CMK+K) for Neos CMS
MIT License
15 stars 2 forks source link

DRAFT: FEATURE: add translations #23

Closed crydotsnake closed 1 year ago

crydotsnake commented 1 year ago

Implements: #22

Sebobo commented 1 year ago

Hi @crydotsnake, I added all the necessary code to make the translations work.

So now if you still want to help here, the task would be to replace the labels with the translate calls like I already did for the SearchBox component.

crydotsnake commented 1 year ago

Hi @Sebobo ! I'm sorry I didn't find time to work on it. 😞 I will rebase my branch and then add the missing translations.

crydotsnake commented 1 year ago

Lol. How did i close my PR now? can you reopen it? @Sebobo

Sebobo commented 1 year ago

Then why did you close it?

Sebobo commented 1 year ago

Only you can do that

crydotsnake commented 1 year ago

That was not on purpose 😅

I cant open it either.

crydotsnake commented 1 year ago

Ah. GitHub closed my PR after i rebased my branch and force pushed them. And now the PR is closed because there arent any changes any more.