search

Sebwite / Magento2-Product-Downloads

Magento 2 Product Downloads extension by Sebwite
https://sebwite.nl
39 stars 35 forks source link

Cannot install module #2

Closed mwienk closed 8 years ago

mwienk commented 8 years ago

Hey,

I cannot compile Magento 2 with the product downloads module enabled. I get the following error:

Errors during compilation:
    Sebwite\ProductDownloads\Model\Adminhtml\Download\Observer
        Incorrect dependency in class Sebwite\ProductDownloads\Model\Adminhtml\Download\Observer in /var/www/vendor/sebwite/magento2-product-downloads/Model/Adminhtml/Download/Observer.php \Magento\Framework\ObjectManagerInterface already exists in context object
    Sebwite\ProductDownloads\Block\Adminhtml\Product\Edit\Tab\Download
        Incorrect dependency in class Sebwite\ProductDownloads\Block\Adminhtml\Product\Edit\Tab\Download in /var/www/vendor/sebwite/magento2-product-downloads/Block/Adminhtml/Product/Edit/Tab/Download.php \Magento\Framework\UrlInterface already exists in context object
\Magento\Framework\App\Config\ScopeConfigInterface already exists in context object
Total Errors Count: 2

This seems to have to do with the constructor parameters being already provided by the context itself (see http://magento-quickies.alanstorm.com/post/138686669515/quick-note-on-already-exists-in-context-object).

mwienk commented 8 years ago

Ohw, it seems to have been fixed, but not released.. Can you release it?

SilvanLaroo commented 8 years ago

This should be fixed in the latest release.