search

Sebwite / magento2-category-sidebar

Magento2 category sidebar extension
63 stars 58 forks source link

Fixed and extended for Magento 2.3.4... #31

Open losttheplot opened 4 years ago

losttheplot commented 4 years ago

Having used this project a few years ago, and having been very grateful to Sebwite for making it available on github, I thought I would bring the latest master up-to-date and suitable for use with Magento 2.3.4. As I don't have time to learn about pull requests and the like, I am attaching my updated master here for anyone who might want to use it.

I have included all fixes mentioned in currently open issues, and have also added: (1) very basic functionality that means the 'enabled' config selector now works, (2) a new config option that allows the menu title to be set, (3) increased category depth option to 8, (4) small CSS changes to look better with the 2.3.4 Luma theme, and (4) a new config option and associated javascript code that automatically opens the menu to the active page (if enabled). I'm no expert, so feel free to improve or correct my work.

Sebwite.zip

rlienhar commented 4 years ago

Thanks for your conclusion of all the fixes, it works great with 2.3.4! It would be great if your work were available in a new version to use Composer directly from the Github.

jtomaszewski commented 4 years ago

Hey @losttheplot , we submitted those changes at our fork in https://github.com/groomershop/magento2-category-sidebar .

You can use it directly by adding the following to composer.json:

    "require": {
        "sebwite/magento2-category-sidebar": "dev-master"
    },
    "repositories": {
        "magento2-category-sidebar": {
            "type": "vcs",
            "url": "git@github.com:groomershop/magento2-category-sidebar.git"
        },
    }

If anybody feels like using / improving that fork feel free to do so, we'll be using this module at our Magento for sure ;)

P.S. @losttheplot I assume the license for your code fixes is the same as the composer.json says (OSL / AFL) ?

losttheplot commented 4 years ago

P.S. @losttheplot I assume the license for your code fixes is the same as the composer.json says (OSL / AFL) ?

Sure - glad to help :)