search

SecKatie / wyzeapy

35 stars 26 forks source link

Partially revert HMS error check #86

Closed brg468 closed 2 months ago

brg468 commented 3 months ago

Fix for https://github.com/SecKatie/ha-wyzeapi/issues/591

The change was discussed here, and since neither Joe or I have the HMS, I was basing the change off of the fact that _get_plan_binding_list_by_user is called once at startup, and the response there is 'message': 'Success' and the typical 2001 code on invalid auth, so the error checker wouldn't function correctly. But apparently _monitoring_profile_active must return a different response than everything else. This is untested of course but is the same response we were checking before.

https://github.com/SecKatie/wyzeapy/pull/83#discussion_r1554494219

brg468 commented 2 months ago

It wasn’t the original reporter but another user with the issue reported it to be working.

https://github.com/SecKatie/ha-wyzeapi/issues/591#issuecomment-2132293657