search

SecUSo / privacy-friendly-qr-scanner

Privacy Friendly QR Code Scanner for Android
https://secuso.aifb.kit.edu/QR_Scanner.php
GNU General Public License v3.0
302 stars 46 forks source link

Add monochrome icon variant for android 13 #170

Closed rec0de closed 10 months ago

rec0de commented 11 months ago

Hi!

I recently upgraded to android 13 and noticed that your app does not yet support monochrome app icons for theming. This makes the app stand out quite a bit when placed next to other apps that do support theming, so I added a simple monochrome version of the app icon.

[privacy]

Here's a before and after showing the themed and un-themed icon next to some other themed apps: unthemed themed

udenr commented 10 months ago

On my Pixel 6 Pro (emulator, API 33) it looks like this: grafik Which device did you use?

rec0de commented 10 months ago

Ah, I see that you added an inset for the non-monochrome version in the app icon xml - I've added that to the monochrome icon as well. Didn't catch that on my phone as the theme seems to provide its own inset for all icons.

I've also slightly bumped the inset on the regular icon so it displays better on round icons.

udenr commented 10 months ago

Looks good to me now! grafik