SecUSo / privacy-friendly-shopping-list

Privacy Friendly App to create and manage shoppings lists on Android devices.
Apache License 2.0
63 stars 37 forks source link

Delete item functions oddly #66

Open IntnsRed opened 5 years ago

IntnsRed commented 5 years ago

I'll try to be accurate with this bug report; my apologies if I'm not. Using the latest version from F-Droid.

When selecting the 3 vertical dots and telling the program to delete, the program displays "Delete Products" at the top of the screen, and a trashcan icon at the bottom left. Clearly it's in delete mode.

The program auto-selects/checks several items with check-marks in the boxes. Tapping on the check-marks makes the program turns the item gray and strikeout the item, but does not un-check the box.

Trying to check the items that have un-checked boxes results in the items being turned gray and struck-out.

Clearly the delete items function is broken.

petermayer commented 5 years ago

Hi @IntnsRed

the check-box and the strike-out are visualisations for two different things. The check-box marks whether an item has been bought. The status of the check-box can only be changed during "normal" use of the shopping list. It is visible in the "Delete Products" screen, but has no functional use there and is irrelevant for deleting items.

The strike-out selects an item for deletion in the "Delete Products" screen. To actually delete the selected items you have to then click on the trash can in the lower right corner. The app should ask you if you are sure you want to delete the items. Whether the check-box is checked or not is irrelevant at this point.

I hope I understood you correctly, but I just checked and for me this worked. Could you please verify, that you are unable to delete products by selecting/striking them out in the "Delete Products" screen and then tap the trash can icon in the lower right corner.

Thanks!

IntnsRed commented 5 years ago

Thanks for the response Peter. And thanks even more for a handy tool -- one that's not only highly functional, but one that I have some confidence in that it's not tracking me or sending my lists of groceries out to third parties. :+1:

I see what you mean about deletion, but if I may suggest, try to imagine that from a clueless user like me. From my perspective, the entire deletion routine functions so oddly that I still don't use it even though you took the time to explain it to me and I verified it works.

IMO this should be a task to revamp for the next version (but I guess it's easy for non-coders to assign you guys work. :-)

petermayer commented 5 years ago

Hi, I agree, the UI could be more intuitive here 😉 It is on our list and I will keep this issue open until the UI has been improved.