search

SecUSo / privacy-friendly-sudoku

Privacy Friendly App to play Sudoku on Android.
https://secuso.org/pfa-sudoku
GNU General Public License v3.0
147 stars 56 forks source link

Android automatic refactor - ObsoleteLayoutParam #19

Closed luiscruz closed 3 years ago

luiscruz commented 7 years ago

Hi (again),

I am developing a tool to automatically refactor Android applications with the goal of improving energy efficiency. This pull request has the changes generated while applying the rule "ObsoleteLayoutParam".

While developing your application's views you might be specifying attributes in a view's artefact that are not necessary due to the nature of its parent. In this PR, those attributes were replaced by a comment.

I have made a previous validation of the changes and they seem correct. Unfortunately, this tool is not able keep the original whitespace of the files, so comparison without ignoring whitespace might be confusing. Please consider the changes and let me know if you agree with them.

Best, Luis

Kamuno commented 3 years ago

Sorry that it took so long to get to this PR. Due to the incoming changes from v3.0 and the merge conflicts, I will close this issue as it is too much work to integrate right now. I will look at the propsed changes and go over them manually after merging v3.0.

Thanks for you contribution, though.