search

SecUSo / privacy-friendly-todo-list

Privacy Friendly App to manage To-Do lists on Android.
Apache License 2.0
84 stars 40 forks source link

Fix problem saving edited subtask details #53

Closed usrhub closed 4 years ago

usrhub commented 5 years ago

I wasn't able to save edited subtask details. Steps to reproduce:

  1. create a todo list
  2. add a task
  3. add some sub tasks
  4. change name of first sub task

expected result:

  1. name of subtask is changed and persists after restart of application

actual result:

  1. name won't be saved to database (even if it gets apparently displayed)

It looks like the "instanceof" check did prevent the db entry.

usrhub commented 5 years ago

Another issue occured after fixing the initial problem. The view isn't properly updated after changes are saved to db, so I had to update the view (with notifyDataSetChanged)

usrhub commented 5 years ago

Depending on the original develepors intention commit e13485e contains a workaround or fix for Issue #43

New behaviour is: Sub tasks are deleted (not moved to recycle bin) if "delete" button in the context menu of sub task list is used.

Note: Behaviour for whole tasks (and their respective sub tasks) is untouched and remains like before.