search

SecUpwN / Spotify-AdKiller

Your Party with Spotify - without ads!
https://github.com/SecUpwN/Spotify-AdKiller
GNU General Public License v3.0
836 stars 84 forks source link

Automatically close, reopen, and resume play when ad starts #111

Open webmasterMeyers opened 5 years ago

webmasterMeyers commented 5 years ago

As per my thought #109

This adds a new CUSTOM_MODE option restart as well as a config file option RESTART_MINIMIZED

webmasterMeyers commented 5 years ago

The minimize function is crap... well, there needs to be a better way of targeting the window. Especially when the first thing to play is an ad, other "active" windows will get minimized.

webmasterMeyers commented 5 years ago

I discovered an unresolved issue. If I am not logged into spotify, it will close and re-open. I never get logged in, so will be caught in the loop. Need to run killall spotify-wrapper.sh in terminal to break the loop, open spotify normally, login, then run spotify killer.

Kabur commented 5 years ago

This is not merged with master yet, right? I tried the "restart" mode but got a warning that it's not supported. It would be pretty neat even without the minimize function tbh.

webmasterMeyers commented 5 years ago

@Kabur it is not merged, but if you use my fork it works. I have been using it for many months now.

It's slightly annoying if you are typing because spotify get focused, but it's worth not listening to ad's.

To be honest, I click on more ads this way, so spotify is still making money.

Kabur commented 5 years ago

@Kabur it is not merged, but if you use my fork it works. I have been using it for many months now.

It's slightly annoying if you are typing because spotify get focused, but it's worth not listening to ad's.

To be honest, I click on more ads this way, so spotify is still making money.

Cool! Thx

Kabur commented 5 years ago

@webmasterMeyers Would it be possible to have it always ignore local files? All local files are recognized as ads for me, resulting in a restart loop hah. If it was in python I'd fix it myself, but alas.

webmasterMeyers commented 5 years ago

@Kabur That is beyond me. I did not write the "detection" code. I just added the new option to close and open.