SecUpwN / Spotify-AdKiller

Your Party with Spotify - without ads!
https://github.com/SecUpwN/Spotify-AdKiller
GNU General Public License v3.0
836 stars 84 forks source link

Missing $ symbol. #114

Closed ryanfox1985 closed 5 years ago

cebtenzzre commented 5 years ago

Quoting man bash, under ARITHMETIC EVALUATION:

Shell variables are allowed as operands; parameter expansion is performed before
the expression is evaluated.  Within an expression, shell variables may also  be
referenced by name without using the parameter expansion syntax.

Therefore explicit parameter expansion syntax (introduced by the $ character) is not necessary to reference the shell variable within the $((...)) (arithmetic expansion) on this line.

ryanfox1985 commented 5 years ago

It's true, the $ symbol is not needed in this line.

I created the pr because I thought when the local player starts I hear the music distorted. I will check the equaliser, thanks!