Call for testing

[Feltzer]

@SecUpwN, @OlegSmelov and everyone else following this project:

I just pushed a large commit to the repo that changes quite a lot of things (a full list of changes can be found in the changelog).

I have done my fair share of testing but because this update changes the entire core of the script I'd really appreciate it if you guys could check if everything works fine for you, including the new modes and automated installer.

Cheers, Feltzer

[el-fran]

hi! excelent repo! im testing on kubuntu 13.10 the scripts work fine, the installer also works fine, the only problem I found is in the launcher, only executing the script manually works

[Feltzer]

@el-fran Thanks for the feedback! A few questions to troubleshoot this issue:

Do you see the launcher in your menu? If so, what happens when you launch it? Does Spotify start?

And concerning the manual method: Do Spotify and the AdKiller script start if you execute the wrapper script? (to test this run spotify-wrapper.sh and check in your task manager if both Spotify and spotify-adkiller.sh are running)

[el-fran]

when i execute the launcher(yes i see it in my menu) apears:

"KDEInit no ha podido lanzar (Could not launch) «spotify-wrapper.sh»: Could not find 'spotify-wrapper.sh' executable".

(i check the .desktop file and edit to point to the exact location (solve the problem) of spotify-wrapper.sh and it works but no init the spotify-AdKiller.sh)

when i execute spotify-wrapper.sh Spotify does Start! but doesn't init the spotify-adkiller.sh

If i execute manualy spotify-AdKiller.sh works fine

PD: Sorry for my bad english! :S

[Feltzer]

Your English is fine :)

It looks like $HOME/bin is not part of your PATH (the PATH are all folders the system reads executable files from).

You basically have two options:

1. Copy spotify-adkiller.sh and spotify-wrapper.sh to a folder that is in the PATH by default (e.g. /usr/local/bin). This will require root privileges
2. Add $HOME/bin or another folder in your home directory to the PATH and copy the scripts to it. This tutorial explains how to do this on KDE for $HOME/local/bin.

[SecUpwN]

@Feltzer, awesome work - I'm amazed! :smile_cat: I just pushed some smaller changes to the Installer script, would you please test it again on Ubuntu? Furthermore, I would like you to change the way where Spotify (AdKiller).desktop gets copied to. Currently, the installer writes it into HOME/.local/share/applications - but this doesn't make it show up on the openSUSE desktop. Please rather push it directly to the desktop, located on openSUSE under /$USER/Desktop. I would have done it myself, but I just can't find the general variable in bash for "Desktop" and I'd like to use one which works for both Ubuntu and openSUSE. Probably too late, it's been a rough day. Please change this and test it again.

[Feltzer]

@SecUpwN Thank you for going over the installer!

I am not quite sure I agree with the CONFIGDIR change:

I chose $XDG_CONFIG_HOME over $HOME/.config because it is more generic and will work on more distros. On Ubuntu and openSUSE it should resolve to $HOME/.config, anyway.

Sometimes, though rarely, the XDG variables aren't set properly. To account for these cases you can set them up like this, where the XDG variable will be substituted for $HOME/.config etc., if it doesn't exist. I will implement this in my next commit.

As for the desktop launcher location: $HOME/.local/share/applications is where almost all menus/launchers (e.g. Unity Dash, Synapse, etc.) read their entries from. You are free to copy the launcher to your desktop, but the standard and preferred way (by almost all distros) is to move desktop launchers to either /usr/share/applications, /usr/local/share/applications or $HOME/.local/share/applications. I think we should keep it this way.

[el-fran]

HI! i can solve the launcher problem (Doing: Copy spotify-adkiller.sh and spotify-wrapper.sh to a folder that is in the PATH by default (e.g. /usr/local/bin). This will require root privileges) , works awesome! but... i don't know how to see the spotify-AdKiller.sh log!

[Feltzer]

@el-fran We don't have an actual logfile, yet, so you will have to execute spotify-adkiller.sh manually for now and copy the output.

Alternatively, you can run spotify-adkiller.sh > adkiller.log which will write the output to adkiller.log.

[el-fran]

Excelent! that was very helpful! it's posible to add it into the script?

thanks for your support ! if any any adds skips I will post the log!

2014-06-09 11:48 GMT-03:00 Feltzer notifications@github.com:

@el-fran https://github.com/el-fran We don't have an actual logfile, yet, so you will have to execute spotify-adkiller.sh manually for now and copy the output.

Alternatively, you can run spotify-adkiller.sh > adkiller.log which will write the output to adkiller.log.

— Reply to this email directly or view it on GitHub https://github.com/SecUpwN/Spotify-AdKiller/issues/12#issuecomment-45498709 .

[Feltzer]

@el-fran Please check out the latest update. I added a new setting to the configuration file that enables debug mode and writes a log file to "$HOME/.Spotify-AdKiller.log". Should make it easier to troubleshoot issues in the future.

[SecUpwN]

@Feltzer, thanks for the latest changes you pushed to the script. I still don't get why openSUSE does not show the Icons from $HOME/.local/share/applications but rather seems to read the directly from the Desktop. On another sidenote, I recognized that clicking on the generated Icon which should launch spotify-wrapper.sh %U does nothing. If manually executing spotify-wrapper.sh %U through terminal, it does not start, nor detect Spotify - but I can also tell you the REASON: Since Spotify does not offer a native installation file for openSUSE yet, I'm using the awesome Spotify-Make. It generates an executable which is located in $Home/Bin/, but is not named "Spotify" but my-spotify. I already tried to solve the whole thing with #2 - but now it seems to have been introduced again. Can you somehow instruct the wrapper to not only start binaries named "Spotify", but rather a generic name?

[Feltzer]

@SecUpwN

I still don't get why openSUSE does not show the Icons from $HOME/.local/share/applications but rather seems to read the directly from the Desktop

I have never used openSUSE or KDE so I am afraid I won't be of much help here. I suppose the reason for the launcher not showing up is that openSUSE reads its menu entries from somewhere else. You could try moving the .desktop file to /usr/local/share/applications or /usr/share/applications and see if it shows up in your menu. This will require root privileges, though.

Can you somehow instruct the wrapper to not only start binaries named "Spotify", but rather a generic name?

It's possible but can be quite dangerous. A call to start *spotify* could start any executable containing spotify, including our own scripts. This would probably lead to a lot of problems and new bug reports.

Instead, I would recommend symlinking my-spotify to spotify. If this works for you we can then add a section to the README.md with this tip.

[SecUpwN]

@Feltzer, thanks for your recommendation, the script works perfectly now. :+1: I'll do some more testing, but I think you can close this Issue now. Rock on, buddy!

[Feltzer]

@SecUpwN No problem. Glad to hear that it's working!

I updated the README accordingly (a4d04d2b7b0caa52d769974e79299423113c5e84) and will close this one.