search

SecUpwN / Spotify-AdKiller

Your Party with Spotify - without ads!
https://github.com/SecUpwN/Spotify-AdKiller
GNU General Public License v3.0
841 stars 83 forks source link

Error: Spotify not found #20

Closed zsteinmetz closed 9 years ago

zsteinmetz commented 9 years ago

Since yesterday, AdKiller doesn't manage to find the Spotify runtime, so that ads remain unblocked. I've already pulled the latest git. Maybe Spotify has changed anything in their way of treating songs? Unfortunately, I haven't had the time to dig deeper. Any ideas?

// Running on Ubuntu 14.10, Spotify 0.9.11.27

kodzak commented 9 years ago

Yes, they did. They change name of window from "Spotify - Linux Preview" to "Spotify Free - Linux Preview". But unfortunately the change something else and app doesn't block ads.

kodzak commented 9 years ago

Any idea what more change or this is all and my script don't work... ?

zsteinmetz commented 9 years ago

I'm still waiting for the first ad to come .. ¯(ツ)/¯

kodzak commented 9 years ago

Good still working i forget change name in other file. I don't check other script spotify-adkiller. :)

philippeluickx commented 9 years ago

+1

zsteinmetz commented 9 years ago

Okay, the workaround is to change WMTITLE="Spotify - Linux Preview" to WMTITLE="Spotify Free - Linux Preview" in both spotify-adkiller.sh and (line 44) and the wrapper script (line 41)

OlegSmelov commented 9 years ago

@zsteinmetz :+1:

I'll update the script tomorrow or the day after. Until then, use this workaround.

SecUpwN commented 9 years ago

Welcome to Spotify-AdKiller, @zsteinmetz! I see that @OlegSmelov has already reviewed your pull requests #21 and #22 - thank you for your awesome commitment here! I have helped @leamas to solve the Issue "GCRYPT_1.2 not found" - can you test his feature branch so that it will be merged?

Feltzer commented 9 years ago

Thanks for the bug report, @zsteinmetz.

For the time being I've put together a solution and pushed it to a new branch. I don't think it's as elegant as it could be, but it does its job. I've added some documentation to the README to account for the changes.

Would love to hear your thoughts on this solution, guys.

Feltzer commented 9 years ago

As per the discussion on #21, I've merged the two pull requests by @zsteinmetz. Spotify-AdKiller should be able to find Spotify again now. Thanks for helping us track this down, guys!