SecUpwN / Spotify-AdKiller

Your Party with Spotify - without ads!
https://github.com/SecUpwN/Spotify-AdKiller
GNU General Public License v3.0
836 stars 83 forks source link

Play Bell sound loop #32

Closed dokker closed 8 years ago

dokker commented 8 years ago

When I set CUSTOM_MODE to interstitial the random track starts to play from my chosen directory flawlessly. In addition a bell starts to play continously from /usr/share/sounds/freedesktop/stereo location. It doesn't stop after the playback change back to spotify.

(By the way It's an awesome script. Big thanks to you!)

VincentChalnot commented 8 years ago

Same thing here, I'm on KUbuntu and the beep stops if I kill VLC. I'm not on CUSTOM_MODE btw.

Feltzer commented 8 years ago

Thanks for the reports, guys.

Looks like VLC remembers the repeat setting across sessions, so when the mode is set to interstitial the audio alert will also be played on repeat. I hadn't come across this bug because I was using mpv on my system.

Seeing how the audio alert was annoying anyway and didn't serve much of a purpose next to the GUI notifications, I decided to remove it (6b6252cc0626633a1d5700d0cfb9ddde940d1d75). Please give the latest master branch a try. The bell should be gone now.

OlegSmelov commented 8 years ago

@Feltzer vlc has a --play-and-exit parameter, perhaps that can help?

Edit: never mind, we already use it.

Feltzer commented 8 years ago

@OlegSmelov : Yeah, the funny thing is that without play-and-exit cvlc wouldn't exit in the first place - even when there's no repeat and the playlist is over.

VLC has quite a few quirks like that, I found. For instance, GUI and CLI sessions share settings like repeat and volume. So if you set the VLC GUI to repeat a video and then mute it, next time you run cvlc to listen to an mp3 you will end up with silence on repeat, and with no way of discerning what the issue is. Very strange behaviour if you ask me.

SecUpwN commented 8 years ago

Thanks for solving bugs like these without my intervention, @Feltzer and @OlegSmelov. I'm still very happy to have you in my team of Collaborators for this project. Thanks for the warm words, @dokker!

VincentChalnot commented 8 years ago

A big thanks for all of you, this project rocks :+1:

dokker commented 8 years ago

It works fine now without bell sounds. Thanks!